Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUP: use a more elegant style when handling some queries #1123

Merged

Conversation

Annopaolo
Copy link
Collaborator

What this PR does / why we need it:

Some relevant comments were left after a merged PR. Implement them.

Which issue(s) this PR fixes:

See @noaccOS comments in #1104 .

Does this PR introduce a user-facing change?
  • Yes
  • No

Some relevant comments were left after a merged PR. Implement them.

Signed-off-by: Arnaldo Cesco <[email protected]>
Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.74%. Comparing base (b681b39) to head (8c24671).
Report is 4 commits behind head on release-1.2.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.2    #1123      +/-   ##
===============================================
+ Coverage        68.72%   68.74%   +0.01%     
===============================================
  Files              323      323              
  Lines             7467     7464       -3     
===============================================
- Hits              5132     5131       -1     
+ Misses            2335     2333       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Annopaolo Annopaolo marked this pull request as ready for review March 5, 2025 11:26
@Annopaolo Annopaolo added minor This issue causes only minor annoyance to the user chore Maintenance chore app:data_updater_plant This issue or pull request is about astarte_data_updater_plant application labels Mar 5, 2025
Copy link
Contributor

@noaccOS noaccOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to myself

@davidebriani davidebriani merged commit 2c9109b into astarte-platform:release-1.2 Mar 5, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:data_updater_plant This issue or pull request is about astarte_data_updater_plant application chore Maintenance chore minor This issue causes only minor annoyance to the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants