-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance DUP Logs Readability: Base64 Encode Astarte Payloads for Improved Decoding and Handling #884
Enhance DUP Logs Readability: Base64 Encode Astarte Payloads for Improved Decoding and Handling #884
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #884 +/- ##
==========================================
+ Coverage 67.52% 68.35% +0.83%
==========================================
Files 264 270 +6
Lines 6435 7028 +593
==========================================
+ Hits 4345 4804 +459
- Misses 2090 2224 +134 ☔ View full report in Codecov by Sentry. |
a229713
to
5497439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is good, however it would be better to include in the log line that you're logging the base64 encoding of the payload, I left a comment as an example.
Also, the title of both the PR and the commit should be updated.
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
5497439
to
3ddfe39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add an indication that displayed payloads are encoded in base64 to the log lines you modified and update PR and commit title (you're not decoding the payload)
3ddfe39
to
aae4c7c
Compare
aae4c7c
to
947f558
Compare
Signed-off-by: Osman Hadzic <[email protected]>
947f558
to
37d496c
Compare
Enhance DUP Logs Readability: Base64 Encode Astarte Payloads for Improved Decoding and Handling
Closes: #721