Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance DUP Logs Readability: Base64 Encode Astarte Payloads for Improved Decoding and Handling #884

Merged

Conversation

osmanhadzic
Copy link
Contributor

@osmanhadzic osmanhadzic commented Dec 7, 2023

Enhance DUP Logs Readability: Base64 Encode Astarte Payloads for Improved Decoding and Handling

Closes: #721

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eaac25f) 67.52% compared to head (37d496c) 68.35%.
Report is 93 commits behind head on master.

Files Patch % Lines
...ib/astarte_data_updater_plant/data_updater/impl.ex 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   67.52%   68.35%   +0.83%     
==========================================
  Files         264      270       +6     
  Lines        6435     7028     +593     
==========================================
+ Hits         4345     4804     +459     
- Misses       2090     2224     +134     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osmanhadzic osmanhadzic force-pushed the astarte_dup_encode_logs branch from a229713 to 5497439 Compare December 20, 2023 12:35
Copy link
Collaborator

@Annopaolo Annopaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is good, however it would be better to include in the log line that you're logging the base64 encoding of the payload, I left a comment as an example.

Also, the title of both the PR and the commit should be updated.

@osmanhadzic osmanhadzic force-pushed the astarte_dup_encode_logs branch from 5497439 to 3ddfe39 Compare January 12, 2024 14:11
@osmanhadzic osmanhadzic requested a review from Annopaolo January 12, 2024 14:12
Copy link
Collaborator

@Annopaolo Annopaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add an indication that displayed payloads are encoded in base64 to the log lines you modified and update PR and commit title (you're not decoding the payload)

@osmanhadzic osmanhadzic force-pushed the astarte_dup_encode_logs branch from 3ddfe39 to aae4c7c Compare January 15, 2024 12:13
@osmanhadzic osmanhadzic requested a review from Annopaolo January 15, 2024 14:18
@osmanhadzic osmanhadzic force-pushed the astarte_dup_encode_logs branch from aae4c7c to 947f558 Compare January 15, 2024 15:35
@osmanhadzic osmanhadzic force-pushed the astarte_dup_encode_logs branch from 947f558 to 37d496c Compare January 16, 2024 07:49
@osmanhadzic osmanhadzic changed the title Add decoding of MQTT payloads to the logger Enhance DUP Logs Readability: Base64 Encode Astarte Payloads for Improved Decoding and Handling Jan 16, 2024
@Annopaolo Annopaolo merged commit 0d96e22 into astarte-platform:master Jan 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Updater Plant: log base64-encoded payloads, instead of Elixir representation
2 participants