Issue 904/escape group name #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinnokdisengir
force-pushed
the
issue-904/escape-group-name
branch
2 times, most recently
from
2751188 to
74a32ac
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #911 +/- ##
==========================================
- Coverage 68.13% 68.11% -0.02%
==========================================
Files 274 276 +2
Lines 7192 7192
==========================================
- Hits 4900 4899 -1
- Misses 2292 2293 +1 ☔ View full report in Codecov by Sentry. |
shinnokdisengir
force-pushed
the
issue-904/escape-group-name
branch
3 times, most recently
from
14769b5 to
0aaeb8c
Compare
Annopaolo
requested changes
Mar 14, 2024
...appengine_api/lib/astarte_appengine_api_web/controllers/device_status_by_group_controller.ex
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/lib/astarte_appengine_api_web/plug/group_name_decoder.ex
Outdated
Show resolved
Hide resolved
.../astarte_appengine_api/test/astarte_appengine_api_web/controllers/groups_controller_test.exs
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/test/astarte_appengine_api_web/plug/group_name_decoder_test.exs
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/test/astarte_appengine_api_web/plug/group_name_decoder_test.exs
Outdated
Show resolved
Hide resolved
shinnokdisengir
force-pushed
the
issue-904/escape-group-name
branch
4 times, most recently
from
c4ba5d0 to
e37a98d
Compare
shinnokdisengir
force-pushed
the
issue-904/escape-group-name
branch
2 times, most recently
from
47d7543 to
c082606
Compare
- Use GroupNameDecoder (Plug) to decode group_name instead implementation inside controllers FIX astarte-platform#904 Signed-off-by: Gabriele Ghio <[email protected]>
shinnokdisengir
force-pushed
the
issue-904/escape-group-name
branch
3 times, most recently
from
98f618f to
59ecbf2
Compare
rbino
requested changes
Mar 20, 2024
apps/astarte_appengine_api/test/astarte_appengine_api_web/plug/group_name_decoder_test.exs
Show resolved
Hide resolved
apps/astarte_appengine_api/test/astarte_appengine_api_web/plug/group_name_decoder_test.exs
Outdated
Show resolved
Hide resolved
.../astarte_appengine_api/test/astarte_appengine_api_web/controllers/groups_controller_test.exs
Show resolved
Hide resolved
apps/astarte_appengine_api/test/astarte_appengine_api_web/plug/group_name_decoder_test.exs
Outdated
Show resolved
Hide resolved
apps/astarte_appengine_api/lib/astarte_appengine_api_web/plug/group_name_decoder.ex
Show resolved
Hide resolved
apps/astarte_appengine_api/lib/astarte_appengine_api_web/plug/group_name_decoder.ex
Outdated
Show resolved
Hide resolved
shinnokdisengir
force-pushed
the
issue-904/escape-group-name
branch
from
59ecbf2 to
998f385
Compare
use of the ExUnitProperties/StreamData (https://hexdocs.pm/stream_data/ExUnitProperties.html) library to parameterize test writing - use of generators (gen all) for creating cases to evaluate and checks - execution of tests via prop tests (check all) - added functional e2e test to "group creates the group with / in group name" - setup test.exs and ci.exs max runs Signed-off-by: Gabriele Ghio <[email protected]>
shinnokdisengir
force-pushed
the
issue-904/escape-group-name
branch
from
998f385 to
3f6b863
Compare
rbino
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug for
group_namedecode implementingGroupNameDecoderAdded
GroupNameDecoderTestunit tests