Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings banned #914

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

shinnokdisengir
Copy link
Contributor

@shinnokdisengir shinnokdisengir commented Mar 13, 2024

Added --warnings-as-errors --force to compiler, no warnings are allowed

  • astarte_appengine_api
  • astarte_data_updater_plant
  • astarte_housekeeping
  • astarte_housekeeping_api
  • astarte_pairing
  • astarte_pairing_api
  • astarte_realm_management
  • astarte_trigger_engine

upgraded libraries:

  • GetText -> 2.24
  • Guardian -> 2.3.2

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 13.98964% with 332 lines in your changes are missing coverage. Please review.

Project coverage is 68.13%. Comparing base (fe5f35c) to head (f5887a6).

Files Patch % Lines
...e_housekeeping/lib/astarte_housekeeping/queries.ex 6.09% 77 Missing ⚠️
...management/lib/astarte_realm_management/queries.ex 3.44% 56 Missing ⚠️
...ib/astarte_data_updater_plant/data_updater/impl.ex 2.85% 34 Missing ⚠️
...ne_api/lib/astarte_appengine_api/device/queries.ex 0.00% 27 Missing ⚠️
...astarte_data_updater_plant/data_updater/queries.ex 4.00% 24 Missing ⚠️
...pps/astarte_pairing/lib/astarte_pairing/queries.ex 23.52% 13 Missing ⚠️
..._housekeeping/lib/astarte_housekeeping/migrator.ex 0.00% 12 Missing ⚠️
..._management/lib/astarte_realm_management/engine.ex 29.41% 12 Missing ⚠️
...ine_api/lib/astarte_appengine_api/device/device.ex 57.14% 9 Missing ⚠️
...api/lib/astarte_appengine_api/rooms/amqp_client.ex 0.00% 6 Missing ⚠️
... and 31 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   68.14%   68.13%   -0.01%     
==========================================
  Files         274      274              
  Lines        7191     7192       +1     
==========================================
  Hits         4900     4900              
- Misses       2291     2292       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shinnokdisengir shinnokdisengir force-pushed the warnings-shooting branch 3 times, most recently from 1acf2c5 to 9969f0d Compare March 13, 2024 16:14
@shinnokdisengir shinnokdisengir force-pushed the warnings-shooting branch 3 times, most recently from 8619cb9 to 4dceaac Compare March 15, 2024 09:31
@shinnokdisengir shinnokdisengir force-pushed the warnings-shooting branch 2 times, most recently from 8e4a18d to c6f67e8 Compare March 18, 2024 10:14
Upgraded libraries to remove warnings

GetText -> 2.24
Guardian -> 2.3.2

Signed-off-by: Gabriele Ghio <[email protected]>
Added --warnings-as-errors --force to compiler,
no warnings are allowed

Apps changed:
- astarte_appengine_api
- astarte_data_updater_plant
- astarte_housekeeping
- astarte_housekeeping_api
- astarte_pairing
- astarte_pairing_api
- astarte_realm_management
- astarte_trigger_engine

Signed-off-by: Gabriele Ghio <[email protected]>
@Annopaolo Annopaolo merged commit c83724f into astarte-platform:master Mar 18, 2024
29 checks passed
@shinnokdisengir shinnokdisengir deleted the warnings-shooting branch March 18, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants