-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings banned #914
Merged
Annopaolo
merged 2 commits into
astarte-platform:master
from
shinnokdisengir:warnings-shooting
Mar 18, 2024
Merged
Warnings banned #914
Annopaolo
merged 2 commits into
astarte-platform:master
from
shinnokdisengir:warnings-shooting
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1acf2c5
to
9969f0d
Compare
Annopaolo
requested changes
Mar 14, 2024
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
apps/astarte_data_updater_plant/lib/astarte_data_updater_plant/data_updater/impl.ex
Outdated
Show resolved
Hide resolved
apps/astarte_pairing_api/lib/astarte_pairing_api/rpc/pairing.ex
Outdated
Show resolved
Hide resolved
8619cb9
to
4dceaac
Compare
8e4a18d
to
c6f67e8
Compare
Upgraded libraries to remove warnings GetText -> 2.24 Guardian -> 2.3.2 Signed-off-by: Gabriele Ghio <[email protected]>
Added --warnings-as-errors --force to compiler, no warnings are allowed Apps changed: - astarte_appengine_api - astarte_data_updater_plant - astarte_housekeeping - astarte_housekeeping_api - astarte_pairing - astarte_pairing_api - astarte_realm_management - astarte_trigger_engine Signed-off-by: Gabriele Ghio <[email protected]>
c6f67e8
to
f5887a6
Compare
Annopaolo
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added --warnings-as-errors --force to compiler, no warnings are allowed
upgraded libraries: