Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection_error handler #943

Closed
wants to merge 2 commits into from

Conversation

eddbbt
Copy link
Contributor

@eddbbt eddbbt commented May 15, 2024

Add :connection_error exception handler when executing a trigger policy, then try to re-enqueue as 408 (timeout) error

resolves #936

Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 62.23%. Comparing base (20233b7) to head (37fffa6).
Report is 3 commits behind head on release-1.1.

Current head 37fffa6 differs from pull request most recent head daa5cd7

Please upload reports for the commit daa5cd7 to get more accurate results.

Files Patch % Lines
...engine/lib/astarte_trigger_engine/policy/policy.ex 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1     #943      +/-   ##
===============================================
- Coverage        62.25%   62.23%   -0.02%     
===============================================
  Files              193      193              
  Lines             4726     4727       +1     
===============================================
  Hits              2942     2942              
- Misses            1784     1785       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddbbt eddbbt marked this pull request as ready for review May 16, 2024 10:42
@eddbbt eddbbt marked this pull request as draft May 16, 2024 11:10
@eddbbt eddbbt marked this pull request as ready for review May 16, 2024 12:16
eddbbt added 2 commits May 21, 2024 14:49
Add :connection_error exception handler when executing a trigger policy

Signed-off-by: Eddy Babetto <[email protected]>
Add tests for connection_error case in trigger handler

Signed-off-by: Eddy Babetto <[email protected]>
@eddbbt eddbbt closed this May 22, 2024
@eddbbt eddbbt deleted the 1.1.1-fix branch May 22, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant