refactor!: use exandra #71
Conversation
noaccOS
force-pushed
the
exandra
branch
3 times, most recently
from
b16c476 to
7e3c1f2
Compare
noaccOS
force-pushed
the
exandra
branch
6 times, most recently
from
a2b76ff to
ec4e13d
Compare
noaccOS
force-pushed
the
exandra
branch
2 times, most recently
from
5c68385 to
d75474b
Compare
lib/astarte_data_access/data.ex
Outdated
| case Enum.to_list(page) do | ||
| [] -> | ||
| {:error, :property_not_set} | ||
| data_id = data_id(device_id, interface_id, endpoint_id, path) |
There was a problem hiding this comment.
It seems that in the Ecto lingo those are usually called clauses. In my opinion, it is a clearer name and it can also be used in the case of datastream interfaces (where the combination of device_id, interface_id, endpoint_id and path does not uniquely identify a single piece of data). So I would suggest something like
| data_id = data_id(device_id, interface_id, endpoint_id, path) | |
| fetch_clauses = fetch_clauses(device_id, interface_id, endpoint_id, path) |
For reference, I'm looking at this part of the Ecto documentation: https://hexdocs.pm/ecto/Ecto.Repo.html#c:get_by/3
This applies in a number of points in the file, but I think you get the idea
lib/astarte_data_access/mappings.ex
Outdated
| alias Astarte.Core.Mapping | ||
| alias Astarte.DataAccess.Astarte.Realm | ||
| alias Astarte.DataAccess.Realms.Endpoint | ||
| alias Astarte.DataAccess.Repo | ||
| alias Astarte.DataAccess.XandraUtils |
There was a problem hiding this comment.
It looks like this is now an unused alias
| alias Astarte.Core.Mapping.Retention | ||
| alias Astarte.Core.Mapping.ValueType | ||
|
|
||
| @primary_key false |
There was a problem hiding this comment.
Just for consistency's sake, I'd suggest adding a @type t :: %__MODULE__{} here too, even if it won't be used.
The same holds for other similar files too, e.g. lib/astarte_data_access/realms/name.ex
There was a problem hiding this comment.
I agree! I was also thinking of using TypedEctoSchema to do that automatically
mix.exs
Outdated
| @@ -71,7 +71,7 @@ defmodule Astarte.DataAccess.Mixfile do | |||
| # Run "mix help deps" to learn about dependencies. | |||
| defp deps do | |||
| [ | |||
| {:xandra, "~> 0.11"}, | |||
| {:exandra, github: "noaccos/exandra", ref: "push-ksolwvtqvqtr"}, | |||
There was a problem hiding this comment.
Damn, do your changes have been merged into exandra?
There was a problem hiding this comment.
This was probably a mistake, yes. We're able to use exandra from main here (although we need custom a exandra in astarte-platform/astarte#1056 but that can be handled on the astarte side)
Signed-off-by: Francesco Noacco <[email protected]>
Signed-off-by: Francesco Noacco <[email protected]>
this also guarantees the port is always an integer Signed-off-by: Francesco Noacco <[email protected]>
we need the updated functions which accept already casted values as well as the database int values. calling the functions without first updating astarte_core results in a crash. Signed-off-by: Francesco Noacco <[email protected]>
Signed-off-by: Francesco Noacco <[email protected]>
due to reworks in xandra, this option is now ignored and always enabled Signed-off-by: Francesco Noacco <[email protected]>
noaccOS
force-pushed
the
exandra
branch
2 times, most recently
from
9d6adf8 to
5e68d42
Compare
add dependencies, repo and resources Signed-off-by: Francesco Noacco <[email protected]>
BREAKING CHANGE: Interface.retrieve_interface_row now returns the struct
Signed-off-by: Francesco Noacco <[email protected]>
so as not to rewrite the tests, for now we still register the cluster used by Exandra under the same name.
use exandra for queries instead of
Xandra.ClusterBREAKING CHANGE: XandraUtils module has been removed
BREAKING CHANGE:
Interface.retrieve_interface_rownow returns the interface struct