Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Astarte group management #18

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

Jusuf95
Copy link
Contributor

@Jusuf95 Jusuf95 commented Nov 18, 2024

Tests for Astarte group management, focusing on the following actions:

  • Creating and listing groups.
  • Adding, listing, and removing devices from groups.

Additionally, updates are made to the resources.py file to include a mygroup variable for group names, and the astarte-ctl-test file is enhanced with:

  • Device ID generation and registration for end-to-end (E2E) tests.
  • Support for the new E2E_DEVICE_TEST_2 environment variable.

These changes are being made to:

  • Ensure that the functionality for creating and managing groups in Astarte is correctly implemented and tested.

  • Improve the reliability of end-to-end testing by automating the device ID generation and supporting multiple test environments via E2E_DEVICE_TEST_2.

  • Enable more comprehensive testing of group-related features in Astarte.

  • Tests were added to verify the creation and listing of groups, as well as the ability to add, list, and remove devices from these groups.

  • A mygroup variable was added to resources.py to make group names more easily configurable and reusable across tests.

  • Modifications to astarte-ctl-test include adding a procedure to dynamically generate device IDs for the E2E tests, and introducing logic to handle the new E2E_DEVICE_TEST_2 environment variable to support additional device testing.

@Jusuf95 Jusuf95 force-pushed the appengine-groups branch 2 times, most recently from 38832ae to fd6d578 Compare November 19, 2024 14:13
-Add device ID generation and registration for E2E tests
-Introduce support for E2E_DEVICE_TEST_2 environment variable.

Signed-off-by: Jusuf <[email protected]>
- Add tests for creating and listing groups.

- Add tests for adding, listing, and removing devices from groups.

- Updated resources.py to include mygroup variable for group name.

Signed-off-by: Jusuf <[email protected]>
Copy link
Collaborator

@osmanhadzic osmanhadzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- Reflects the addition of a new device in the E2E environment
Signed-off-by: Jusuf <[email protected]>
@Annopaolo Annopaolo merged commit d04e452 into astarte-platform:main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants