Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests astartectl utils commands for device ID #20

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Tests astartectl utils commands for device ID #20

merged 2 commits into from
Nov 21, 2024

Conversation

Jusuf95
Copy link
Contributor

@Jusuf95 Jusuf95 commented Nov 20, 2024

Tests for astartectl utils commands related to device ID generation, validation, and conversion.

To ensure the correctness and reliability of astartectl utility functions for device ID operations, including:

  • Generating and validating random device IDs.
  • Converting device IDs to and from UUIDs.
  • Computing device IDs from strings and byte arrays.

Created tests for:

  • Generating and validating device IDs: Using astartectl to generate random IDs and validate them.
  • Converting device IDs to and from UUIDs: Ensuring accurate conversion and reversibility.
  • Computing device IDs from strings and bytes: Verifying consistent results between string and byte computations.

@Jusuf95
Add tests for Astarte device ID utilities
955a44d 
- Add test for generating and validating device IDs.
- Add test for Astarte device ID computation from string and bytes
- Add test for converting device IDs to/from UUIDs.

Signed-off-by: Jusuf <[email protected]>
osmanhadzic
osmanhadzic reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@osmanhadzic osmanhadzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add pytest -v ./tests/utils as the first command in test.sh.

@Jusuf95
Add packages configuration to pyproject.toml
1e855cb 
- Include app_engine and utils in the project packages

Signed-off-by: Jusuf <[email protected]>
@Jusuf95 Jusuf95 requested a review from osmanhadzic November 21, 2024 13:49
@Annopaolo Annopaolo merged commit 658d139 into astarte-platform:main Nov 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osmanhadzic osmanhadzic osmanhadzic approved these changes

@Annopaolo Annopaolo Annopaolo approved these changes

Assignees

@Jusuf95 Jusuf95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jusuf95 @Annopaolo @osmanhadzic