-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chan_websocket: Allow additional URI parameters to be added to the outgoing URI. #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
cherry-pick-to: 20 |
61232b7
to
d366933
Compare
Workflow PRCheck completed successfully |
d366933
to
d15e453
Compare
Workflow PRCheck completed successfully |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is kind of opinionated... but some of the line wrapping in this seems a bit excessive... I see a lot of lines wrapped at 60-70 characters? Even if unrolled onto a single line, most of them would be under 90 chars, which is the (I believe obsolete) formatting rule mentioned in the documentation.
@InterLinked1 Are you talking about the commit message/PR description or the source files themselves? |
I'm talking about the source code itself |
Hmmm. I'm going to add a check to make sure the parameters are in fact encoded (or don't need encoding). |
d15e453
to
7732834
Compare
…tgoing URI. * Added a new option to the WebSocket dial string to capture the additional URI parameters. * Added a new API ast_uri_verify_encoded() that verifies that a string either doesn't need URI encoding or that it has already been encoded. * Added a new API ast_websocket_client_add_uri_params() to add the params to the client websocket session. * Added XML documentation that will show up with `core show application Dial` that shows how to use it. Resolves: asterisk#1352 UserNote: A new WebSocket channel driver option `v` has been added to the Dial application that allows you to specify additional URI parameters on outgoing connections. Run `core show application Dial` from the Asterisk CLI to see how to use it.
7732834
to
8eb0f67
Compare
I've added validation to the uri params to make sure each name and value either doesn't need to be encoded or is already encoded. |
Workflow PRCheck completed successfully |
URI parameters.
either doesn't need URI encoding or that it has already been encoded.
to the client websocket session.
core show application Dial
that shows how to use it.
Resolves: #1352
UserNote: A new WebSocket channel driver option
v
has been added to theDial application that allows you to specify additional URI parameters on
outgoing connections. Run
core show application Dial
from the Asterisk CLIto see how to use it.