feat: expose reconnection retries #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mostafaroshdy1
force-pushed
the
original
branch
from
a955de9 to
26ccf39
Compare
MazenElSayegh
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created to expose re-connection options because whenever asterisk is stopped and started the WebSocketMaxRetries is reached too quickly (within a minute).
after this PR it will be possible for devs to specify their preferred configuration like this
this.ari = await ariClient.connect(Host, Username, Password, { maxRetries: 1000, retryDelay: 100, retryMaxDelay: 1000 * 60 * 5 });