Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrong-backtracking scenario #230

Merged
merged 2 commits into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions scenarios/backtracking/wrong-backtracking-basic.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name = "wrong-backtracking-basic"
description = """There are two packages, `a` and `b`. We select `a` with `a==2.0.0` first, and then `b`, but `a==2.0.0` conflicts with all new versions of `b`, so we backtrack through versions of `b`.

We need to detect this conflict and prioritize `b` over `a` instead of backtracking down to the too old version of `b==1.0.0` that doesn't depend on `a` anymore."""

[expected]
satisfiable = true

[resolver_options]
universal = true

[expected.packages]
a = "1.0.0"
b = "2.0.9"

[root]
requires = ["a", "b"]

[packages.a.versions]
"1.0.0" = {}
"2.0.0" = {}

[packages.too-old.versions]
"1.0.0" = {}

[packages.b.versions]
# We must not backtrack to this very old versions
"1.0.0" = { requires = ["too-old"] }
"2.0.0" = { requires = ["a==1.0.0"] }
"2.0.1" = { requires = ["a==1.0.0"] }
"2.0.2" = { requires = ["a==1.0.0"] }
"2.0.3" = { requires = ["a==1.0.0"] }
"2.0.4" = { requires = ["a==1.0.0"] }
"2.0.5" = { requires = ["a==1.0.0"] }
"2.0.6" = { requires = ["a==1.0.0"] }
"2.0.7" = { requires = ["a==1.0.0"] }
"2.0.8" = { requires = ["a==1.0.0"] }
"2.0.9" = { requires = ["a==1.0.0"] }
2 changes: 1 addition & 1 deletion src/packse/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ def build_package_distributions(
default_tag_wheel = dist
break
if not default_tag_wheel:
raise BuildError("No wheel found with tag `py3-none-any`.")
raise BuildError("No wheel found with tag `py3-none-any`", "")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature requires two strings, this would have failed-on-raise.


# Since we always build a universal wheel, we just create copies of it for other platforms
# which means we're lying about the compatibility of the wheel but it will always be installable
Expand Down
Loading