Reduce diff further

src/internal/arena.rs

@@ -86,9 +86,15 @@ impl<T: fmt::Debug> fmt::Debug for Arena<T> {
     }
 }
 
+impl<T> Default for Arena<T> {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
 impl<T> Arena<T> {
-    pub fn new() -> Arena<T> {
-        Arena { data: Vec::new() }
+    pub fn new() -> Self {
+        Self { data: Vec::new() }
     }
 
     pub fn alloc(&mut self, value: T) -> Id<T> {

src/lib.rs

@@ -217,7 +217,6 @@
 //! do not exist in your cache.
 
 #![warn(missing_docs)]
-#![allow(clippy::all, unreachable_pub)]
 
 pub mod error;
 pub mod package;

src/report.rs

@@ -45,7 +45,7 @@ pub enum DerivationTree<P: Package, VS: VersionSet, M: Eq + Clone + Debug + Disp
 pub enum External<P: Package, VS: VersionSet, M: Eq + Clone + Debug + Display> {
     /// Initial incompatibility aiming at picking the root package for the first decision.
     NotRoot(P, VS::V),
-    /// There are no versions in the given set for this package. A string reason is included.
+    /// There are no versions in the given set for this package.
     NoVersions(P, VS),
     /// Incompatibility coming from the dependencies of a given package.
     FromDependencyOf(P, VS, P, VS),

src/solver.rs

@@ -401,11 +401,9 @@ impl<P: Package, VS: VersionSet> DependencyProvider for OfflineDependencyProvide
             None => {
                 Dependencies::Unavailable("its dependencies could not be determined".to_string())
             }
-            Some(dependencies) => Dependencies::Available(
-                dependencies
-                    .into_iter()
-                    .map(|(p, vs)| (p.clone(), vs.clone())),
-            ),
+            Some(dependencies) => {
+                Dependencies::Available(dependencies.iter().map(|(p, vs)| (p.clone(), vs.clone())))
+            }
         })
     }
 }