Add a reason to the NoVersions incompatibility
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Feb 5, 2024
Previously, whenever we encountered a missing package we would throw an error without information about why the package was requested. This meant that if a transitive dependency required a missing package, the user would have no idea why it was even selected. Here, we track `NotFound` and `NoIndex` errors as `NoVersions` incompatibilities with an attached reason. Improves our test coverage for `--no-index` without `--find-links`. The [snapshots](https://github.com/astral-sh/puffin/pull/1241/files#diff-3eea1658f165476252f1f061d0aa9f915aabdceafac21611cdf45019447f60ec) show a nice improvement. I think this will also enable backtracking to another version if some version of transitive dependency has a missing dependency. I'll write a scenario for that next. Requires astral-sh/pubgrub#22
konstin
pushed a commit
that referenced
this pull request
Mar 6, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
Mar 22, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
May 2, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
May 7, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
May 8, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
May 21, 2024
* Add a `reason` to the `NoVersions` incompatibility * Make optional
konstin
pushed a commit
that referenced
this pull request
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to report versions that are missing due to the package missing from the registry.