Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: formatting check in CI #437

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

hamirmahal
Copy link
Contributor

No description provided.

@hamirmahal
Copy link
Contributor Author

Summary

This change checks for file formatting discrepancies.

@hamirmahal
Copy link
Contributor Author

Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know your thoughts on this type of change. I was also thinking about adding a similar check for linting errors.

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Apr 3, 2024
@MichaReiser
Copy link
Member

Thank you

@MichaReiser MichaReiser merged commit 6dff120 into astral-sh:main Apr 3, 2024
6 checks passed
@hamirmahal
Copy link
Contributor Author

You’re welcome.

@hamirmahal hamirmahal deleted the feat/formatting-check-in-ci branch April 3, 2024 16:20
hamirmahal added a commit to hamirmahal/ruff-vscode that referenced this pull request Apr 11, 2024
This reverts commit `6dff120dcaf49abcf4315954ea7268e1c153c0a2`
because there's a cleaner way to implement it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants