-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve deprecation warnings #685
Conversation
b4c303b
to
2cd9620
Compare
I'm a bit unsure on the flow of (5) and (6), any suggestions are appreciated. |
For 4: I find it a bit confusing that we suggest setting to on For 5: I'm unsure what the info message is trying to tell me. Does it mean I have to upgrade to use the native server or is it only a hint that I'd be using an experimental version if I keep using the older version? 6 doesn't seem ideal but it's also not terrible. Maybe we could add a note to the migration guide that using the native server requires at least Ruff 0.3.5 to give users a heads up? |
Thank you for the feedback.
Yes, "auto" is the default value. I'll remove the
That message already existed, but I think I can improve it:
Note that there's also this info message that'll be present so overall it says that the auto behavior found the Ruff version which does not include stable server so will use ruff-lsp instead:
Yeah, that makes sense. |
## Summary Related: astral-sh/ruff-vscode#685 This PR removes the deprecation warning for VS Code client and removes the version check as well as it's not needed for other editors. ## Test Plan While testing astral-sh/ruff-vscode#685 with local `ruff-lsp` on this branch, VS Code should only provides notification from the extension and not the one from `ruff-lsp`.
Summary
Related: astral-sh/ruff-lsp#522
Test Plan
1. User explicitly sets native server "on" with legacy settings
settings.json
:Logs:
Notification:
2. User explicitly sets native server "off" with no legacy settings
settings.json
:Logs:
Notification:
3. User explicitly sets native server "off" with legacy settings
settings.json
:Logs:
Notification:

4. Auto behavior with legacy settings
settings.json
:Logs:
Notification:

5. Auto behavior with non-stable
ruff server
Same as (4) with Ruff 0.5.2 installed. The notification message is the same except that the logs include an additional mesage:
6. Auto behavior with Ruff without the
server
commandThis uses Ruff 0.3.4 and will first provide a warning message same as (4) and when the user sets
nativeServer
toon
, they'll get an error: