Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back issue template #15651

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #15641.

Test Plan

@InSyncWithFoo
Copy link
Contributor Author

The description field is not shown to the user but mandatory nevertheless.

@MichaReiser
Copy link
Member

Nice, thank you. @zanieb this looks good to me, wdyt?

@InSyncWithFoo just to confirm. Clicking on "new issue" now goes directly to the editor without showing a selector?

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Jan 21, 2025
@InSyncWithFoo
Copy link
Contributor Author

Clicking on "new issue" now goes directly to the editor without showing a selector?

Yes, that's correct.


actionlint seems to be complain about something, just like last time. I don't know what that is (line endings?).

@AlexWaygood
Copy link
Member

actionlint seems to be complain about something, just like last time. I don't know what that is (line endings?).

(it's actually prettier that was complaining, not actionlint. I don't know what it was complaining about, but line endings seems plausible.)

@zanieb
Copy link
Member

zanieb commented Jan 21, 2025

Should we align these with the uv templates? or just restore this first?

@zanieb
Copy link
Member

zanieb commented Jan 21, 2025

See

@MichaReiser
Copy link
Member

We should restore them first. Adopting something similar to uv requires some more effort

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. Thanks for updating the template. Let's see how it goes. We can iterate on the template as we see fit.

@MichaReiser MichaReiser merged commit 6fe404a into astral-sh:main Jan 22, 2025
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the issue-template branch January 22, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back issue template
4 participants