[ty] introduce DivergentType
#20312
Merged
[ty] introduce DivergentType
#20312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
|
1 task
mtshiba
requested review from
carljm,
AlexWaygood,
sharkdp and
dcreager
as code owners
carljm
reviewed
Sep 9, 2025
carljm
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Looks good, thank you! I put together a proof-of-concept to show how we can use this type to address an infinite-tuple case in implicit instance attribute (given a small change in Salsa) -- that's enough to convince me that this will be generally useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From #17371
In #17371,
DivergentTypewas introduced to prevent type inference for recursive functions from diverging and causing panics. This turned out to be useful for other divergent type inferences (#17371 (comment)), so I extracted the introduction part ofDivergentTypeinto this PR so that we can use it without waiting for the merge of #17371.Note that this PR only introduces
DivergentTypeand does not actually address divergent type inference yet. Please refer to https://github.com/astral-sh/ruff/pull/17371/files#diff-20b910c6e20faa962bb1642e111db1cbad8e66ace089bdd966ac9d7f9fa99ff2R542-R622 etc. when implementing handling of divergence suppression using this type.Test Plan