Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy::manual_let_else (pedantic) #939

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix clippy::manual_let_else (pedantic) #939

merged 1 commit into from
Nov 28, 2022

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 28, 2022

This is part of nightly clippy::pedantic for MSRV ≥ 1.65.

@andersk
Fix clippy::manual_let_else (pedantic)
b83a6dd 
This is part of nightly clippy::pedantic for MSRV ≥ 1.65.

Signed-off-by: Anders Kaseorg <[email protected]>
@charliermarsh
Copy link
Member

I was a hesitant to change these given that rustfmt doesn't yet support them (rust-lang/rustfmt#4914 -- unless that's the wrong issue), but it's a small enough cases that it's probably worth fixing clippy.

@charliermarsh charliermarsh merged commit 6c8021e into astral-sh:main Nov 28, 2022
@andersk andersk deleted the clippy-manual-let-else branch July 1, 2023 20:40
@andersk andersk mentioned this pull request Jul 2, 2023
Merged
charliermarsh pushed a commit that referenced this pull request Jul 3, 2023
@andersk
Format let-else with rustfmt nightly (#5461)
df13e69 
Support for `let…else` formatting was just merged to nightly
(rust-lang/rust#113225). Rerun `cargo fmt` with Rust nightly 2023-07-02
to pick this up. Followup to #939.

Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andersk @charliermarsh