Skip to content

Commit

Permalink
Remove unnnecesary Windows stack size changes (#2345)
Browse files Browse the repository at this point in the history
This is already set by `command`.
  • Loading branch information
charliermarsh authored Mar 10, 2024
1 parent bb2d06c commit ec83151
Showing 1 changed file with 1 addition and 43 deletions.
44 changes: 1 addition & 43 deletions crates/uv/tests/pip_install.rs
Original file line number Diff line number Diff line change
Expand Up @@ -848,11 +848,6 @@ fn install_git_public_https() {

let mut command = command(&context);
command.arg("uv-public-pypackage @ git+https://github.com/astral-test/uv-public-pypackage");
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}

uv_snapshot!(command
, @r###"
Expand Down Expand Up @@ -945,11 +940,6 @@ fn install_git_private_https_pat() {
command.arg(format!(
"uv-private-pypackage @ git+https://{token}@github.com/astral-test/uv-private-pypackage"
));
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}

uv_snapshot!(filters, command
, @r###"
Expand Down Expand Up @@ -988,11 +978,6 @@ fn install_git_private_https_pat_at_ref() {

let mut command = command(&context);
command.arg(format!("uv-private-pypackage @ git+https://{user}{token}@github.com/astral-test/uv-private-pypackage@6c09ce9ae81f50670a60abd7d95f30dd416d00ac"));
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}

uv_snapshot!(filters, command, @r###"
success: true
Expand Down Expand Up @@ -1027,11 +1012,6 @@ fn install_git_private_https_pat_and_username() {

let mut command = command(&context);
command.arg(format!("uv-private-pypackage @ git+https://{user}:{token}@github.com/astral-test/uv-private-pypackage"));
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}

uv_snapshot!(filters, command
, @r###"
Expand Down Expand Up @@ -1091,11 +1071,6 @@ fn reinstall_no_binary() {
// The first installation should use a pre-built wheel
let mut command = command(&context);
command.arg("anyio").arg("--strict");
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}
uv_snapshot!(command, @r###"
success: true
exit_code: 0
Expand All @@ -1121,11 +1096,6 @@ fn reinstall_no_binary() {
.arg("--no-binary")
.arg(":all:")
.arg("--strict");
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}
uv_snapshot!(command, @r###"
success: true
exit_code: 0
Expand Down Expand Up @@ -1157,11 +1127,6 @@ fn reinstall_no_binary() {
.arg("--reinstall-package")
.arg("anyio")
.arg("--strict");
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}
uv_snapshot!(filters, command, @r###"
success: true
exit_code: 0
Expand Down Expand Up @@ -1613,14 +1578,7 @@ fn direct_url_zip_file_bunk_permissions() -> Result<()> {
"opensafely-pipeline @ https://github.com/opensafely-core/pipeline/archive/refs/tags/v2023.11.06.145820.zip",
)?;

let mut command = command(&context);
if cfg!(all(windows, debug_assertions)) {
// TODO(konstin): Reduce stack usage in debug mode enough that the tests pass with the
// default windows stack of 1MB
command.env("UV_STACK_SIZE", (2 * 1024 * 1024).to_string());
}

uv_snapshot!(command
uv_snapshot!(command(&context)
.arg("-r")
.arg("requirements.txt")
.arg("--strict"), @r###"
Expand Down

0 comments on commit ec83151

Please sign in to comment.