Add smoke test script in Python #11628
Conversation
zanieb
had a problem deploying
to
uv-test-publish
GitHub Actions
Error
zanieb
force-pushed
the
zb/smoke-test
branch
from
7462b1a to
ef64649
Compare
zanieb
had a problem deploying
to
uv-test-publish
GitHub Actions
Error
zanieb
force-pushed
the
zb/smoke-test
branch
from
ef64649 to
d7e29fc
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
|
Great it failed on aarch64 as desired! https://github.com/astral-sh/uv/actions/runs/13419135061/job/37487489440?pr=11628 |
zanieb
had a problem deploying
to
uv-test-publish
GitHub Actions
Failure
scripts/smoke-test/commands.sh
Outdated
| @@ -0,0 +1,7 @@ | |||
| # Note this is not a real shell-script, it's parsed by `smoke-test/__main__.py` and executed | |||
There was a problem hiding this comment.
We probably could just have a list of shell scripts here and actually run them with a shell, but just doing something that fulfills the current needs right now.
There was a problem hiding this comment.
Can we just inline this as a string into smoke-test/__main__.py? It feels a little safer than reading and executing this file.
There was a problem hiding this comment.
I wanted syntax highlighting, but... okay :)
There was a problem hiding this comment.
I did this but... idk I actually do care about syntax highlighting so there can be comments. I don't want to clutter __main__.py as we add more commands and I don't want to have to deal with Python syntax.
There was a problem hiding this comment.
I think I'm going to do what I said above and just invoke separate shell scripts.
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
zanieb
force-pushed
the
zb/smoke-test
branch
from
1c7a09f to
6585fc1
Compare
zanieb
temporarily deployed
to
uv-test-publish
GitHub Actions
Inactive
I wanted to consolidate these anyway, and apparently it's a huge pain to make a Windows task fail early via GitHub's PowerShell setup so I implement this in Python instead.