Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add forkdiff gh-page #14

Merged
merged 8 commits into from
May 13, 2024
Merged

Chore: Add forkdiff gh-page #14

merged 8 commits into from
May 13, 2024

Conversation

quasystaty1
Copy link
Contributor

Description

we need a static webpage to show changes made to astria-geth fork, this should be used both internally and externally.
using a forkdiff tool to create a static webpage.

Changes

add a fork.yaml file structs the changes view and define the commits to compare with
pages.yaml workflow deploys to gh-pages

Currently deploying on PR for testing.

Copy link
Member

@joroshiba joroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small comments but looks fine. If we update the fork and the pull request stuff I'm fine to merge. Annoying that it doesn't work otherwise but fine.

# The GH actions bot is used by default if you didn't specify the two fields.
# You can swap them out with your own user credentials.
user_name: github-actions[bot]
user_email: 41898282+github-actions[bot]@users.noreply.github.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

fork.yaml Outdated
- "go.mod"
- "fork.yaml"
- ".github/*"
- ".github/workflows/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably use v4

@quasystaty1 quasystaty1 merged commit a9326e1 into main May 13, 2024
1 check passed
@quasystaty1 quasystaty1 deleted the quasystaty1/forkdiff branch May 13, 2024 20:46
bharath-123 pushed a commit that referenced this pull request May 29, 2024
### Description
we need a static webpage to show changes made to astria-geth fork, this
should be used both internally and externally.
using a [forkdiff](https://github.com/protolambda/forkdiff) tool to
create a static webpage.

### Changes
add a fork.yaml file structs the changes view and define the commits to
compare with
pages.yaml workflow deploys to gh-pages

Currently deploying on PR for testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants