Fix GetGenesisInfo after monorepo #1291 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
requested review from
joroshiba,
mycodecrafting and
noot
as code owners
joroshiba
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
can you run go fmt ./... over this pr? Otherwise lgtm. Hold off on merging until we update protos after merge of astriaorg/astria#1291
|
@joroshiba |
github-merge-queue bot
pushed a commit
to astriaorg/astria
that referenced
this pull request
Jul 25, 2024
## Summary Changed execution API `rollup_id` to use primitive `RollupId` instead of bytes. ## Background `RollupId` is defined in primitives protobuf specs, but `astria.execution.v1alpha2.GenesisInfo.rollup_id` was still using type bytes instead of the primitive type. ## Changes - Changed execution `rollup_id` to be of type `RollupId`. - Regenerated Rust sources with protobuf compiler. - Changed affected conductor functions to utilize `RollupId` instead of bytes. - Updated `evm-stack` and `evm-rollup` versions. ## Testing With changes in `astria-geth`, passes smoke-test. ## Breaking Changelist - Execution API changed, requires corresponding `astria-geth` [changes](astriaorg/astria-geth#38) to function properly. - Will require followup PR to update geth `devTag` to `latest` once geth PR is merged. ## Related Issues With `astria-geth` [#38](astriaorg/astria-geth#38), closes #1287 --------- Co-authored-by: Jordan Oroshiba <[email protected]> Co-authored-by: Richard Janis Goldschmidt <[email protected]>
github-merge-queue bot
pushed a commit
to astriaorg/astria
that referenced
this pull request
Jul 25, 2024
## Summary Update EVM-Rollup Geth `devTag` after #1291 and astria-geth [#38](astriaorg/astria-geth#38). ## Background #1291 relied on astria-geth PR [#38](astriaorg/astria-geth#38) for `evm-rollup` chart. Now that both PRs have been merged, the `devTag` can be updated to `latest`. ## Changes - Updated geth `devTag` to `latest` in `evm-rollup` `values.yaml`. - Updated `evm-rollup` and `evm-stack` versions. ## Testing Passing e2e tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR in tandem with astriaorg/astria#1291. Adjusts
GetGenesisInfoto utilize primitive typeRollupIdinstead ofbytes.Changes
GetGenesisInfoto use primitiveRollupId.RollupId.