Skip to content

Commit

Permalink
fix(charts): shorten metric port names (#1048)
Browse files Browse the repository at this point in the history
## Summary
Shortens the port names which were too long, making it impossible to
enable metrics.
  • Loading branch information
joroshiba authored May 6, 2024
1 parent c3a3021 commit 0cbcfcd
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion charts/evm-rollup/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.15.2
version: 0.15.3

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
12 changes: 6 additions & 6 deletions charts/evm-rollup/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ spec:
selector:
app: {{ .Values.config.rollup.name }}-astria-dev-cluster
ports:
- name: geth-metrics
- name: geth-metr
port: {{ .Values.ports.metrics }}
targetPort: geth-metrics
- name: composer-metrics
targetPort: geth-metr
- name: composer-metr
port: {{ .Values.ports.composerMetrics }}
targetPort: composer-metrics
- name: conductor-metrics
targetPort: composer-metr
- name: conductor-metr
port: {{ .Values.ports.conductorMetrics }}
targetPort: conductor-metrics
targetPort: conductor-metr
{{- end }}
6 changes: 3 additions & 3 deletions charts/evm-rollup/templates/servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,23 +17,23 @@ spec:
matchLabels:
app: {{ .Values.config.rollup.name }}-astria-dev-cluster
endpoints:
- port: geth-metrics
- port: geth-metr
path: /debug/metrics/prometheus
{{- with .Values.config.rollup.serviceMonitor.interval }}
interval: {{ . }}
{{- end }}
{{- with .Values.config.rollup.serviceMonitor.scrapeTimeout }}
scrapeTimeout: {{ . }}
{{- end }}
- port: composer-metrics
- port: composer-metr
path: /
{{- with .Values.config.rollup.serviceMonitor.interval }}
interval: {{ . }}
{{- end }}
{{- with .Values.config.rollup.serviceMonitor.scrapeTimeout }}
scrapeTimeout: {{ . }}
{{- end }}
- port: conductor-metrics
- port: conductor-metr
path: /
{{- with .Values.config.rollup.serviceMonitor.interval }}
interval: {{ . }}
Expand Down
6 changes: 3 additions & 3 deletions charts/evm-rollup/templates/statefulsets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ spec:
name: execution-grpc
{{- if .Values.config.rollup.metrics.enabled }}
- containerPort: {{ .Values.ports.metrics }}
name: geth-metrics
name: geth-metr
{{- end }}
resources:
{{- toYaml .Values.resources.geth | trim | nindent 12 }}
Expand Down Expand Up @@ -109,7 +109,7 @@ spec:
{{- if .Values.config.rollup.metrics.enabled }}
ports:
- containerPort: {{ .Values.ports.composerMetrics }}
name: composer-metrics
name: composer-metr
{{- end }}
resources:
{{- toYaml .Values.resources.composer | trim | nindent 12 }}
Expand All @@ -126,7 +126,7 @@ spec:
{{- if .Values.config.rollup.metrics.enabled }}
ports:
- containerPort: {{ .Values.ports.conductorMetrics }}
name: conductor-metrics
name: conductor-metr
{{- end }}
volumes:
- name: {{ .Values.config.rollup.name }}-executor-scripts-volume
Expand Down
2 changes: 1 addition & 1 deletion charts/sequencer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.13.3
version: 0.13.4

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
4 changes: 2 additions & 2 deletions charts/sequencer/templates/service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ spec:
port: {{ .Values.ports.cometBFTMETRICS }}
targetPort: cometbft-metric
{{- if .Values.config.sequencer.metrics.enabled }}
- name: sequencer-metric
- name: seq-metric
port: {{ .Values.ports.sequencerMetrics }}
targetPort: sequencer-metric
targetPort: seq-metric
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/sequencer/templates/servicemonitor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
matchLabels:
{{- include "sequencer.selectorLabels" . | nindent 6 }}
endpoints:
- port: sequencer-metric
- port: seq-metric
path: /
{{- with .Values.serviceMonitor.interval }}
interval: {{ . }}
Expand Down
2 changes: 1 addition & 1 deletion charts/sequencer/templates/statefulsets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ spec:
name: sequencer-grpc
{{- if .Values.config.sequencer.metrics.enabled }}
- containerPort: {{ .Values.ports.sequencerMetrics }}
name: sequencer-metric
name: seq-metric
{{- end }}
- name: cometbft
imagePullPolicy: IfNotPresent
Expand Down

0 comments on commit 0cbcfcd

Please sign in to comment.