fix(sequencer): ICS 20 Withdrawals Missing current_block_timestamp #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Changed protobuf, astria-core, and dependent code to utilize generic `Bytes` instead of the default `Vec<u8>` to utilize zero-copy deserialization from Protobuf and make type conversion cheaper. ## Background Previously, some components were utilizing `Bytes` and some were utilizing `Vec<u8>` as the generated Rust types when converting from Protobuf `bytes`. ## Changes - Adjusted Protobuf compiler to use `Bytes` for all Astria paths. - Edited conversions to/from `Raw` in `astria-core` to utilize `prost::bytes::Bytes`. - Adjusted code which relied on `Vec<u8>`. ## Testing Passing all tests. ## Related Issues closes #674
## Summary Changes to production templates of the charts, namely secrets, volumes, configmap and deployment ## Background Production deployments through GCP provider has small template errors ## Changes - composer secret private key naming - evm-bridge-withdrawer condition - sequencer-faucet now uses fixed image - evm-faucet condition and secret naming - evm-rollup otel values templating ## Testing - deployed a local kubernetes cluster with all services - this changes were originally made while deploying dusk-9 production network ## Related Issues closes #1358
steezeburger
changed the title
steezeburger
changed the title
* feature/ibc-e2e-smoke-test: fix expected withdraw amount in tests
quasystaty1
reviewed
Aug 14, 2024
| sequencer: | ||
| repo: ghcr.io/astriaorg/sequencer | ||
| tag: "0.14.0" | ||
| devTag: sha-b4c5d1c |
There was a problem hiding this comment.
Should this be a specific devTag sha instead of latest? can add a new single-ics20.yml for now instead or manually change when using.
There was a problem hiding this comment.
It should be latest, but the image hasn't been built yet because the fix is in this pr
## Summary celestia-node image update to v0.14.1 which fixes memory leaks ## Background Image used per celestia-node is outdated ## Changes - celestia-node image `v0.13.4 -> v0.14.1` ## Testing locall kubernetes cluster with all services deployed and firm blocks confirmed
github-actions
bot
added
conductor
|
Fixed by #1389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick hack to fix ics20 withdrawals for e2e ibc testing
Background
During ibc testing, was experiencing error from Penumbra "Missing current_block_timestamp".
Changes
EpochManagerfor now. ShouldTesting
Tested as part of ibc e2e tests here #1284
Breaking Changelist