feat(sequencer): rework fee handling #1526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanoroshiba
commented
Sep 19, 2024
| @@ -1,14 +1,9 @@ | |||
| use cnidarium::StateWrite; | |||
|
|
|||
| /// This trait is a verbatim copy of `cnidarium_component::ActionHandler`. | |||
There was a problem hiding this comment.
Deleted comment because this didn't seem like a super accurate representation of ActionHandler anymore, but can revert if others disagree.
ethanoroshiba
commented
Sep 19, 2024
| .wrap_err("failed to add to block fees")?; | ||
| state | ||
| .decrease_balance(self.bridge_address, &self.fee_asset, fee) | ||
| .decrease_balance(from, &self.fee_asset, fee) |
There was a problem hiding this comment.
Should bridge sudo change action be deducting the fee from the signer as opposed to the bridge address?
ethanoroshiba
requested review from
a team,
joroshiba,
SuperFluffy and
noot
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implemented
calculate_and_pay_fees()for each action, required by a new trait boundFeeHandlerinActionHandler.Background
This is meant to streamline and standardize fee handling in a way that keeps the same functionality, but makes it more difficult to introduce bugs in fee handling in the future. Offline discussion suggested changing the return type of
execute_transaction()to be our own type as opposed toVec<Event>, but I think this would be best done in a followup, since deposit ABCI events are also recorded viaapply().Changes
fee_handlerwith traitFeeHandlerand structFee.FeeHandlertoActionHandler, and created new functioncheck_execute_and_pay_fees(), which first callscheck_and_execute()and then callsFeeHandler::calculate_and_pay_fees().check_and_execute()tocalculate_and_pay_fees().Vec<Fee>. This allows forend_block()to still pay out all fees at the end of the block, and create fee ABCI events at that time.Testing
All previous tests passing.
Breaking Changelist
app:state_ext::storage_keys_are_unchangedsnapshotRelated Issues
closes #1369
closes #1145
closes #1382