Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conductor): fix flaky restart test #1575

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix(conductor): fix flaky restart test #1575

merged 1 commit into from
Sep 27, 2024

Conversation

ethanoroshiba
Copy link
Contributor

Summary

Fixed flaky conductor restart test.

Background

soft_and_firm::conductor_restart_on_permission_denied would sometimes fail due to receiving the firm block first.

Changes

  • Added short delay to firm block response so the conductor will always receive the soft block first.

Testing

Test now passing.

Related Issues

closes #1566

@github-actions github-actions bot added the conductor pertaining to the astria-conductor crate label Sep 26, 2024
@ethanoroshiba ethanoroshiba marked this pull request as ready for review September 26, 2024 18:08
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner September 26, 2024 18:08
Fraser999
Fraser999 approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@Fraser999 Fraser999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed repeatedly for me.

@ethanoroshiba ethanoroshiba added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 790af57 Sep 27, 2024
54 checks passed
@ethanoroshiba ethanoroshiba deleted the ENG-864/fix_conductor_restart_test branch September 27, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fraser999 Fraser999 Fraser999 approved these changes

Assignees
No one assigned
Labels
conductor pertaining to the astria-conductor crate testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test conductor_restarts_on_permission_denied fails sporadically
2 participants
@ethanoroshiba @Fraser999