Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): remove once_cell #1576

Merged
merged 2 commits into from
Sep 27, 2024
Merged

chore(all): remove once_cell #1576

merged 2 commits into from
Sep 27, 2024

Conversation

ethanoroshiba
Copy link
Contributor

Summary

Migrated from usage of once_cell to LazyLock

Background

Rust 1.81 stabilized LazyLock, we can now remove our dependency on once_cell.

Changes

  • Removed once_cell as a dependency
  • Replaced all implementations of once_cell::sync::Lazy to std::sync::LazyLock

Testing

Passing all tests

Related Issues

closes #1520

@github-actions github-actions bot added conductor pertaining to the astria-conductor crate sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer labels Sep 26, 2024
@ethanoroshiba ethanoroshiba changed the base branch from ENG-819/allow_to_expect to main September 26, 2024 18:31
@ethanoroshiba ethanoroshiba marked this pull request as ready for review September 26, 2024 18:45
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner September 26, 2024 18:45
Copy link
Member

@SuperFluffy SuperFluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat.

@ethanoroshiba ethanoroshiba added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@ethanoroshiba ethanoroshiba added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Sep 27, 2024
@ethanoroshiba ethanoroshiba added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 3bf4652 Sep 27, 2024
43 checks passed
@ethanoroshiba ethanoroshiba deleted the ENG-817/remove_once_cell branch September 27, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer pertaining to composer conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate sequencer-relayer pertaining to the astria-sequencer-relayer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace once_cell by sync primitives added in 1.80
2 participants