chore(bridge-contracts): add snapshot test for memo #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraser999
requested review from
a team,
joroshiba,
SuperFluffy and
noot
as code owners
joroshiba
reviewed
Oct 25, 2024
crates/astria-bridge-contracts/src/snapshots/astria_bridge_contracts__tests__memo_snapshot.snap
Outdated
Show resolved
Hide resolved
noot
approved these changes
Oct 29, 2024
SuperFluffy
reviewed
Nov 5, 2024
SuperFluffy
requested changes
Nov 5, 2024
SuperFluffy
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a snapshot test for the memo field being populated from the withdrawal info.
Background
The new test should serve to emphasize that the schema of the memo field is part of the API and changes to this could well be breaking.
Changes
memo_to_jsonand removed the generic parameter.Testing
This is a test.
Changelogs
No updates required - this is only adding a test.
Related Issues
Closes #1752.