refactor(sequencer): provide storage and snapshot types #1801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds new storage types to sequencer and replaces bare usage of cnidarium equivalent types.
Background
We want to become less coupled to the raw
cnidarium
APIs, and we also want to provide a cache of recently-read values.Changes
storage::Storage
type, wrapping thecnidarium::Storage
type.storage::Snapshot
type, wrapping thecnidarium::Snapshot
type and including a cache of fetched values.storage.release().await;
which should probably have been the case before this PR.StateDelta<Snapshot>
andStateDelta<StateDelta<Snapshot>>
.Testing
Added unit tests for the new types covering the non-trivial methods (many new methods simply call directly through to the equivalent inner method and don't need independent unit tests).
Changelogs
Changelogs updated.
Metrics
astria_sequencer_verifiable_cache_hit
counterastria_sequencer_verifiable_cache_miss
counterastria_sequencer_verifiable_cache_item_total
histogramastria_sequencer_non_verifiable_cache_hit
counterastria_sequencer_non_verifiable_cache_miss
counterastria_sequencer_non_verifiable_cache_item_total
histogramRelated Issues
Closes #1435.