feat(astro) pass config to vite alias #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathantneal
changed the title
jonathantneal
changed the title
jonathantneal
force-pushed
the
jn.improve-config-alias
branch
from
a20f01f
to
03ce722
Compare
jonathantneal
force-pushed
the
jn.improve-config-alias
branch
from
03ce722
to
2f4259e
Compare
|
Would you be willing to review this, @bluwy? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This changes
vite-plugin-config-aliasso that its aliases are passed directly to Vite.By passing aliases from jsconfig.json or tsconfig.json files directly into Vite’s built-in alias configuration, non-JS files like CSS can now aliases.
Testing
The current test for
tsconfig.jsononly targets JS resolution, and so I’ve added a test forjsconfig.jsonthat also target CSS resolution.For an example of the issue, here is what current happens when an alias is used inside a CSS file:
https://stackblitz.com/edit/github-khftu4?file=src/pages/_index.css
For an example of the fix, here is what happens if we push the tsconfig to aliases instead:
https://stackblitz.com/edit/github-khftu4-d255tn?file=src/pages/_index.css
Docs
/cc @withastro/maintainers-docs for feedback!