Feat!: disc refactoring #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put each disc in its own file and directory, so it's easy to see what belongs to what. Removed the inclination argument from ThinDisc, since with PrecessingDisc and the like, it would be better to add general modifiers.
fjebaker
force-pushed
the
fergus/disc-refactor
branch
from
fc21edd
to
9ca4d9c
Compare
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 69.51% 69.30% -0.21%
==========================================
Files 62 66 +4
Lines 2693 2704 +11
==========================================
+ Hits 1872 1874 +2
- Misses 821 830 +9
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.