Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: try to improve the visibility criteria #165

Merged
merged 5 commits into from
Sep 9, 2023
Merged

Fix: try to improve the visibility criteria #165

merged 5 commits into from
Sep 9, 2023

Commits on Sep 9, 2023

  1. feat: add dot product check to visibility criteria 

    Also compute the dot product between disc normal and velocity when
trying to ascertain whether a point on the disc is visible or not.

Caution against using just the projected radius, as this is biases
towards visibility when the disc is steeply inclined. Prefer checking
the Cartesian distance instead.
    @fjebaker
    fjebaker committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    e6a6143 View commit details
    Browse the repository at this point in the history

  2. fix: missing aux in unpack_solution_full

    @fjebaker
    fjebaker committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    76808a7 View commit details
    Browse the repository at this point in the history

  3. fix: make plotting aware of status of geodesic when deciding the midp… 

    …oint for interpolation
    @fjebaker
    fjebaker committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    f66fd67 View commit details
    Browse the repository at this point in the history

  4. fix: the most annoying bug so far related to jacobians and thick discs

    @fjebaker
    fjebaker committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    0feb2a9 View commit details
    Browse the repository at this point in the history

  5. test: update thick disc test value

    @fjebaker
    fjebaker committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    156458e View commit details
    Browse the repository at this point in the history