Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix macvtaps #303

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix macvtaps #303

merged 2 commits into from
Dec 3, 2024

Conversation

PatrickDaG
Copy link
Contributor

@PatrickDaG PatrickDaG commented Dec 3, 2024

#291 introduced two bugs related to macvtaps:

  • multiple definition of tapMultiQueue in the passthru attributes.
    I'm guessing the on I removed shouldn't be there as it's just the other one without
    the default case.
  • wrong type of binScripts.macvtap-down

@PatrickDaG PatrickDaG changed the title fix evaluation error in runner.nix fix macvtaps Dec 3, 2024
@RooSoft
Copy link

RooSoft commented Dec 3, 2024

This breaks my setup, had to revert to a prior commit... thanks guys for working this through.

I guess I would be better off not refering to the bleeding edge...

@astro astro merged commit 1a62cb5 into astro:main Dec 3, 2024
50 checks passed
@astro
Copy link
Owner

astro commented Dec 3, 2024

macvtap is a feature I do not test myself. Thank you very much for doing this for me!

I create git tags from time to time after new features have stabilized.

@RooSoft
Copy link

RooSoft commented Dec 3, 2024

Working now with the bleeding edge, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants