Merge config files into pyproject.toml #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonymilne
commented
Apr 13, 2023
There was a problem hiding this comment.
Note this config has not been moved into pyproject.toml since it's implied by the profile="black" that's already there - see https://pycqa.github.io/isort/docs/configuration/profiles.html.
antonymilne
commented
Apr 13, 2023
| no_implicit_reexport = true | ||
|
|
||
| # More strict checks for library code | ||
| [[tool.mypy.overrides]] |
There was a problem hiding this comment.
This syntax is a bit different from the .ini file - see https://mypy.readthedocs.io/en/stable/config_file.html#using-a-pyproject-toml.
|
@astrojuanlu are these CI failures genuine? I don't see why the test fails and looks like it's failing on |
|
The CI failures are because these tests still expect the cookiecutter template, see gh-3 |
Closed
astrojuanlu
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does some of #4.
I didn't merge
tox.inibecause it looks more complicated and I wasn't sure whether you'd actually want to do that or would prefer to keep it separate?I checked that all was ok by generating a new project from the template and running
validate-pyproject. (I'll make a separate issue about this in a second.)