-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FivetranOperatorAsync hook and trigger to handle reschedule changes #25
Conversation
c1ac696
to
cc49fec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we add this param here too while initialising trigger
trigger=FivetranTrigger( |
trigger=FivetranTrigger( |
Added the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont we need tests to be added for operator and sensor for reschedule change?
I have added the relevant tests in hook and triggerer. I can add tests in for sensor and operator as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the below questions:
- Does
rescheduled_for
exists & applies forconnector_details["schedule_type"] == "manual"
in FiveTran? - Were we able to test the issue fix E2E with a DAG mentioned in the PR description wrt
When connector has schedule_type manual and sync_status reschedule, connector will hang as Fivetran expects manual restart. This pr automatically (or optionally manually) handles that restart.?
If the answer is yes to both the questions, then the changes look good to me.
|
I have tested it locally using the following task:
In this PR, we automatically handle the case of restart of the sync. |
@phanikumv I have updated the test for various scenarios: 4539e03 |
closes: FivetranOperatorAsync waits forever in case of reschedule #21