Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #148 compatibility issue with great_expectations 1.0.0 #149

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Fix #148 compatibility issue with great_expectations 1.0.0 #149

merged 2 commits into from
Aug 30, 2024

Conversation

mostafasayed5
Copy link
Contributor

@mostafasayed5 mostafasayed5 commented Aug 29, 2024 •
edited
Loading

airflow-provider-great-expectations is not compatible with great_expectations 1.0.0

Closes #148

airflow-provider-great-expectations is not compatible with great_expectations 1.0.0

CheckpointResult has been removed so the following import is currently failing!
from great_expectations.checkpoint.types.checkpoint_result import CheckpointResult

https://github.com/astronomer/airflow-provider-great-expectations/blob/main/great_expectations_provider/operators/great_expectations.py#L30

great-expectations PR that made the changes: great-expectations/great_expectations#9824

@mostafasayed5
Update setup.cfg
1cf7ec6 
airflow-provider-great-expectations is not compatible with great_expectations 1.0.0
@mostafasayed5
Update setup.cfg
24d5ee7
@mostafasayed5 mostafasayed5 changed the title Update setup.cfg Fix #148 compatible issue with great_expectations 1.0.0 Aug 29, 2024
@mostafasayed5 mostafasayed5 changed the title Fix #148 compatible issue with great_expectations 1.0.0 Fix #148 compatibility issue with great_expectations 1.0.0 Aug 30, 2024
@pankajastro pankajastro mentioned this pull request Aug 30, 2024
Open
@pankajastro
Copy link
Contributor

Created issue #150 to enable 1.0.0 support

@pankajastro pankajastro merged commit 98aa49c into astronomer:main Aug 30, 2024
6 checks passed
This was referenced Sep 2, 2024
Closed
Merged
pankajastro added a commit that referenced this pull request Sep 2, 2024
@pankajastro
Release 0.2.9 (#152)
fa5537f 
* Release 0.2.9

[FEATURE] Add schema as a template field by @antelmoa add schema as a template field #135
[BUGFIX] Fix compatibility issue with great_expectations 1.0.0 by @mostafasayed5 in Fix #148 compatibility issue with great_expectations 1.0.0 #149
closes: #151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajastro pankajastro pankajastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility issue with great_expectations 1.0.0
2 participants
@mostafasayed5 @pankajastro