Allow for database override for Snowflake conn_type
#160
+164
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the database parameter or via the data asset name using the format database.schema.table
for more information, see https://pre-commit.ci
|
cc: @tatiana |
|
cc: @pankajkoti |
|
@jroach-astronomer thank you! this fixes #158 too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address issue #111 and provides users the ability to override the
databasein a Snowflake connection. This can be done in two different ways:databaseparameter that can be set when defining the Task.data_asset_namein the form<database>.<schema>.<table>.Both approaches have been tested and validated.