Add GCP_CLOUD_RUN_JOB execution mode #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @ags-de, Thank you so much for your contribution. Please let us know if you need any support. |
ags-de
changed the title
dosubot
bot
added
size:L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
+ Coverage 95.72% 95.77% +0.05%
==========================================
Files 64 65 +1
Lines 3672 3744 +72
==========================================
+ Hits 3515 3586 +71
- Misses 157 158 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ags-de
force-pushed
the
gcpcloudrun-executor
branch
from
855dba3
to
e30de3b
Compare
|
@ags-de thank you very much for working so quickly on the changes requested. When you get a chance, please, rebase on the main branch. |
ags-de
force-pushed
the
gcpcloudrun-executor
branch
from
db25ad2
to
ab2f009
Compare
ags-de
force-pushed
the
gcpcloudrun-executor
branch
from
ab2f009
to
5dcec92
Compare
ags-de
force-pushed
the
gcpcloudrun-executor
branch
from
342a7bf
to
0bb09a1
Compare
3 tasks
ags-de
force-pushed
the
gcpcloudrun-executor
branch
from
51b8a24
to
e55bc97
Compare
ags-de
force-pushed
the
gcpcloudrun-executor
branch
from
e55bc97
to
8e549ca
Compare
|
Hello @tatiana, The branch is rebased and I also fixed a few typos in docs. It should be ready to go. |
tatiana
reviewed
Sep 25, 2024
tatiana
reviewed
Sep 25, 2024
Co-authored-by: Tatiana Al-Chueyr <[email protected]>
slords
pushed a commit
to slords/astronomer-cosmos
that referenced
this pull request
Sep 26, 2024
Added new `GCP_CLOUD_RUN_JOB` execution mode that triggers Google Cloud Platform's Cloud Run Job instance with dbt model in it. It extends Airflow's `CloudRunExecuteJobOperator` and overrides Cloud Run Job's container with dbt command generated by cosmos. Note: `CloudRunExecuteJobOperator` has `container_overrides` parameter implemented in `apache-airflow-providers-google==10.13.0` which is supported by `airflow >=2.6.0`. Resolves astronomer#1149 Co-authored-by: Agata Zalewska <[email protected]> Co-authored-by: Tatiana Al-Chueyr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new
GCP_CLOUD_RUN_JOBexecution mode that triggers Google Cloud Platform's Cloud Run Job instance with dbt model in it.It extends Airflow's
CloudRunExecuteJobOperatorand overrides Cloud Run Job's container with dbt command generated by cosmos.Note:
CloudRunExecuteJobOperatorhascontainer_overridesparameter implemented inapache-airflow-providers-google==10.13.0which is supported byairflow >=2.6.0.Related Issue(s)
resolves #1149
Breaking Change?
None, the new execution mode is optional.
Checklist