Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Upgrade actions/upload-artifact from v2 to v3 to address deprecation #1205

Closed

Conversation

kesompochy
Copy link
Contributor

Description

Upgrade actions/upload-artifact from v2 to v3.
This update is necessary to address the deprecation of v2. The action is failing with the following error:

Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v2`. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

The repository's README contains the following warning:

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024. [Learn more.](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/) Similarly, v1/v2 are scheduled for deprecation on June 30, 2024. Please update your workflow to use v4 of the artifact actions. This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers.

Therefore, we need to upgrade the action to address this issue.

Note: I submitted this PR directly because this PR addresses a straightforward update. If an issue discussion is preferred, please let me know and I'll create one promptly.

Related Issue(s)

Breaking Change?

No.

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 12, 2024
Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit a2de540
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/66e2d0837580330008bb658f

@dosubot dosubot bot added the area:ci Related to CI, Github Actions, or other continuous integration tools label Sep 12, 2024
@tatiana
Copy link
Collaborator

tatiana commented Sep 19, 2024

Hi @kesompochy, thank you very much for contributing to this and improving our CI.

Just yesterday, we merged #1208, which upgrades to upgrade-artifact to v4.

We're still facing the issue:

Run coverage combine ./coverage/coverage*/.coverage
Couldn't combine from non-existent path './coverage/coverage*/.coverage'

By adding include-hidden-files: true to our CI, similar to what was done in https://github.com/astronomer/astro-provider-ray/pull/60/files, will overcome the issue

@tatiana
Copy link
Collaborator

tatiana commented Sep 19, 2024

I just noticed this last fix to add include-hidden-files: true was done in #1210, so I'm closing this PR. But thank you very much, again, for helping out on this.!

@tatiana tatiana closed this Sep 19, 2024
@kesompochy
Copy link
Contributor Author

@tatiana , thanks for the update. I appreciate you taking the time to review my PR and provide information about the recent changes. I'm glad the issue has been resolved.
Thank you again for your time and for maintaining such an active project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Related to CI, Github Actions, or other continuous integration tools size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants