Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: dbt compile task as node in dbt graph #1226

Closed
wants to merge 2 commits into from

Conversation

pankajkoti
Copy link
Contributor

related: #1134

Alternative to #1224

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for sunny-pastelito-5ecb04 canceled.

Name Link
🔨 Latest commit d9a9124
🔍 Latest deploy log https://app.netlify.com/sites/sunny-pastelito-5ecb04/deploys/66f3ee4f15f22e0008398e08

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 30.10753% with 65 lines in your changes missing coverage. Please review.

Project coverage is 94.09%. Comparing base (3414513) to head (d9a9124).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cosmos/operators/airflow_async.py 0.00% 35 Missing ⚠️
cosmos/operators/local.py 32.35% 23 Missing ⚠️
cosmos/converter.py 50.00% 5 Missing ⚠️
cosmos/airflow/graph.py 75.00% 1 Missing ⚠️
cosmos/dbt/graph.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
- Coverage   95.72%   94.09%   -1.64%     
==========================================
  Files          64       65       +1     
  Lines        3672     3759      +87     
==========================================
+ Hits         3515     3537      +22     
- Misses        157      222      +65     
Flag Coverage Δ
94.09% <30.10%> (-1.64%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti
Copy link
Contributor Author

We decided to go ahead with the approach in #1224. Hence closing this PR in favour of that approach.

@pankajkoti pankajkoti closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant