-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS]: Adds Welcome Section and "What Is Cosmos" Blurb to Home Page #1251
Conversation
- Updated `index.rst` to enhance the documentation structure - Included a welcome section and detailed explanation of Cosmos - Expanded example usage with dbt graph and more usage details
✅ Deploy Preview for sunny-pastelito-5ecb04 canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
=======================================
Coverage 95.73% 95.73%
=======================================
Files 67 67
Lines 3965 3965
=======================================
Hits 3796 3796
Misses 169 169 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor punctuation and grammar fixes but everything else looks great!
Co-authored-by: yanmastin-astro <[email protected]>
Co-authored-by: yanmastin-astro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor formatting fix to remove line break in list
Co-authored-by: yanmastin-astro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would be nice to confirm if the path to the jaffle_shop_dbt_graph.png
image works well. Anyhow, I guess we should be able to quickly iterate through that later in a subsequent PR if we see any issues with it.
Bug fixes * Fix ``DbtVirtualenvBaseOperator`` to use correct virtualenv Python path by kesompochy in #1252 * Fix displaying dbt docs as menu item in Astro by @tatiana in #1280 * Fix: Replace login by user for clickhouse profile by @petershenri in #1255 Enhancements * Improve dbt Docs Hosting Debugging -- Update dbt_docs_not_set_up.html by @johnmcochran in #1250 * Minor refactor on VirtualenvOperators & add test for PR by @tatiana in #1253 Docs * Add Welcome Section and "What Is Cosmos" Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update ``CODEOWNERS`` to track all files by @pankajkoti in #1284 * Fix release after the ``raw`` rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template ``bug.yml`` - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244" error: pathspec 'Is' did not match any file(s) known to git error: pathspec 'Cosmos Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update CODEOWNERS to track all files by @pankajkoti in #1284 * Fix release after the raw rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template bug.yml - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244
Bug fixes * Fix ``DbtVirtualenvBaseOperator`` to use correct virtualenv Python path by kesompochy in #1252 * Fix displaying dbt docs as menu item in Astro by @tatiana in #1280 * Fix: Replace login by user for clickhouse profile by @petershenri in #1255 Enhancements * Improve dbt Docs Hosting Debugging -- Update dbt_docs_not_set_up.html by @johnmcochran in #1250 * Minor refactor on VirtualenvOperators & add test for PR by @tatiana in #1253 Docs * Add Welcome Section and "What Is Cosmos" Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update ``CODEOWNERS`` to track all files by @pankajkoti in #1284 * Fix release after the ``raw`` rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template ``bug.yml`` - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244" error: pathspec 'Is' did not match any file(s) known to git error: pathspec 'Cosmos Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update CODEOWNERS to track all files by @pankajkoti in #1284 * Fix release after the raw rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template bug.yml - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244
Bug fixes * Fix ``DbtVirtualenvBaseOperator`` to use correct virtualenv Python path by @kesompochy in #1252 * Fix displaying dbt docs as menu item in Astro by @tatiana in #1280 * Fix: Replace login by user for clickhouse profile by @petershenri in #1255 Enhancements * Improve dbt Docs Hosting Debugging -- Update dbt_docs_not_set_up.html by @johnmcochran in #1250 * Minor refactor on VirtualenvOperators & add test for PR by @tatiana in #1253 Docs * Add Welcome Section and "What Is Cosmos" Blurb to Home Page by @cmarteepants and @yanmastin-astro in #1251 * Update the URL for sample dbt docs hosted in Astronomer S3 bucket by @pankajkoti in #1283 * Add a dedicated scarf tracking pixel to readme by @cmarteepants in #1256 Others * Update ``CODEOWNERS`` to track all files by @pankajkoti in #1284 * Fix release after the ``raw`` rst directive disabled was disabled in PyPI by @tatiana in #1282 * Update issue template ``bug.yml`` - cosmos version update in the dropdown by @pankajkoti in #1275 * Pre-commit hook updates in #1285, #1274, #1254, #1244
Summary
DbtDag
Changes
index.rst
(+72 additions, -19 deletions)jaffle_shop_dbt_graph.png
Related Issue(s)
Part of #1225