Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix access to the dbt docs menu item outside of Astro cloud #1312

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Fix access to the dbt docs menu item outside of Astro cloud #1312

merged 3 commits into from
Nov 12, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Nov 11, 2024

Since Cosmos 1.7.1, users who do not use Astro Cloud started facing 'Access is Denied' when accessing the dbt docs menu item.

This was an unintended side effect of the fix for Astro users to be able to see that menu item, introduced in #1280

Closes: #1309

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2024 •
edited
Loading

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 298c21c
Status: ✅  Deploy successful!
Preview URL: https://6d79d4f6.astronomer-cosmos.pages.dev
Branch Preview URL: https://fix-1309.astronomer-cosmos.pages.dev

View logs

@tatiana tatiana mentioned this pull request Nov 11, 2024
Closed
1 task
@tatiana
Fix dbt docs outside of Astro
1342d84 
Since Cosmos 1.7.1, users who do not use Astro started getting 'Access is Denied' when trying to access the dbt docs menu item.

This was an uninted side effect of the fix for Astro users to be able to see that menu item, introduced in: #1280

Closes: #1309
@tatiana tatiana marked this pull request as ready for review November 11, 2024 14:51
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. area:plugin Related to the Cosmos AirflowPlugin. dbt:docs Primarily related to dbt docs command or functionality labels Nov 11, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (1840c32) to head (298c21c).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          67       67           
  Lines        3976     3980    +4     
=======================================
+ Hits         3811     3815    +4     
  Misses        165      165

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pankajkoti
pankajkoti approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice fix.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@tatiana tatiana merged commit 2b21f4c into main Nov 12, 2024
65 checks passed
@tatiana tatiana deleted the fix-1309 branch November 12, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajkoti pankajkoti pankajkoti approved these changes

Assignees
No one assigned
Labels
area:plugin Related to the Cosmos AirflowPlugin. dbt:docs Primarily related to dbt docs command or functionality lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] after upgrading from 1.6 to 1.7.1, docs does not open in airflow
2 participants
@tatiana @pankajkoti