Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vulnerability issue on docs dependency #1313

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fix vulnerability issue on docs dependency #1313

merged 2 commits into from
Nov 13, 2024

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Nov 11, 2024

Fix: https://github.com/astronomer/astronomer-cosmos/security/dependabot/8

More details about the vulnerability:

Airflow versions before 2.10.3 have a vulnerability that allows authenticated users with audit log access to see sensitive values in audit logs which they should not see. When sensitive variables were set via airflow CLI, values of those variables appeared in the audit log and were stored unencrypted in the Airflow database. While this risk is limited to users with audit log access, upgrading to Airflow 2.10.3 or a later version is recommended, which addresses this issue. Users who previously used the CLI to set secret variables should manually delete entries with those variables from the log table.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 11, 2024
@tatiana tatiana added this to the Cosmos 1.8.0 milestone Nov 11, 2024
@dosubot dosubot bot added the area:dependencies Related to dependencies, like Python packages, library versions, etc label Nov 11, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 11, 2024

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b490c4
Status: ✅  Deploy successful!
Preview URL: https://3456946d.astronomer-cosmos.pages.dev
Branch Preview URL: https://vulnerability-8.astronomer-cosmos.pages.dev

View logs

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.85%. Comparing base (92330f5) to head (4b490c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          67       67           
  Lines        3983     3983           
=======================================
  Hits         3818     3818           
  Misses        165      165           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/requirements.txt Outdated Show resolved Hide resolved
docs/requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once one of the suggestions is applied.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
pankajkoti added a commit that referenced this pull request Nov 13, 2024
It appears we have a flaky Kubernetes test that failed in PR #1313. As
shown in the error log
[here](https://github.com/astronomer/astronomer-cosmos/actions/runs/11796817624/job/32867560902?pr=1313#step:7:473),
the PostgreSQL pod did not reach the ready state and instead entered an
error status. Since the cause of the error status is unclear, this PR
introduces a status check for the PostgreSQL pod to ensure it becomes
fully running and healthy. If the pod enters an ERROR state, we now run
a `kubectl describe` command on the pod to capture the event logs for
debugging. The test will also exit with an error code of 1 to prevent
further execution.

related: #1319
https://github.com/astronomer/astronomer-cosmos/security/dependabot/8

Airflow versions before 2.10.3 have a vulnerability that allows authenticated users with audit log access to see sensitive values in audit logs which they should not see. When sensitive variables were set via airflow CLI, values of those variables appeared in the audit log and were stored unencrypted in the Airflow database. While this risk is limited to users with audit log access, it is recommended to upgrade to Airflow 2.10.3 or a later version, which addresses this issue. Users who previously used the CLI to set secret variables should manually delete entries with those variables from the log table.
@tatiana tatiana merged commit 8ec46d2 into main Nov 13, 2024
65 checks passed
@tatiana tatiana deleted the vulnerability-8 branch November 13, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dependencies Related to dependencies, like Python packages, library versions, etc lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants