Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for source node rendering #1327

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Nov 15, 2024

Description

Add example DAG to run integration tests for source node rendering feature

Success Run: https://github.com/astronomer/astronomer-cosmos/actions/runs/11853052767/job/33032439737?pr=1327#step:7:449

Failed Run For Dbt < 1.5 https://github.com/astronomer/astronomer-cosmos/actions/runs/11852864026/job/33031862113?pr=1327

Related Issue(s)

closes: #1155
closes: #1229

Breaking Change?

Checklist

  • I have made corresponding changes to the documentation (if required)
  • I have added tests that prove my fix is effective or that my feature works

Copy link

cloudflare-workers-and-pages bot commented Nov 15, 2024

Deploying astronomer-cosmos with  Cloudflare Pages  Cloudflare Pages

Latest commit: 42e485d
Status: ✅  Deploy successful!
Preview URL: https://2f437abe.astronomer-cosmos.pages.dev
Branch Preview URL: https://source-rendering-test.astronomer-cosmos.pages.dev

View logs

@pankajastro pankajastro marked this pull request as ready for review November 15, 2024 08:56
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. area:rendering Related to rendering, like Jinja, Airflow tasks, etc area:testing Related to testing, like unit tests, integration tests, etc labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.03%. Comparing base (8ec46d2) to head (42e485d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
+ Coverage   95.85%   96.03%   +0.17%     
==========================================
  Files          67       67              
  Lines        3983     3983              
==========================================
+ Hits         3818     3825       +7     
+ Misses        165      158       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajastro pankajastro mentioned this pull request Nov 15, 2024
1 task
@pankajastro pankajastro added this to the Cosmos 1.8.0 milestone Nov 15, 2024
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you very much, @pankajastro !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 15, 2024
@tatiana tatiana merged commit 9a19084 into main Nov 15, 2024
65 checks passed
@tatiana tatiana deleted the source_rendering_test branch November 15, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rendering Related to rendering, like Jinja, Airflow tasks, etc area:testing Related to testing, like unit tests, integration tests, etc lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Render source nodes [Test] Add integration test for source node rendering
2 participants