Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use moto-server to create a local S3 service. #39

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Oct 3, 2024

Creates a new test mode, local_s3, which spins up a local s3 instance, using moto_server. This operates like a pretty real s3 instance, and drops all of its data after termination.

Adds a directory of files that are copied onto the s3 instance when it spins up.

Note that s3 has some quirks around directories not being real. We also add some logic that incorporates this in expectations.

Copy link

github-actions bot commented Oct 3, 2024

Before [f3cdc02] After [cc97abb] Ratio Benchmark (Parameter)
3.63±1s 3.10±0.9s ~0.85 benchmarks.time_computation
1.05k 3.99k 3.81 benchmarks.mem_list

Click here to view all benchmarks.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@delucchi-cmu delucchi-cmu merged commit 83de3bf into main Oct 4, 2024
7 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/local_s3 branch October 4, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants