Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix smoke test (remove test, update read_hats) #44

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix smoke test (remove test, update read_hats) #44

merged 2 commits into from
Oct 29, 2024

Conversation

delucchi-cmu
Copy link
Contributor

@delucchi-cmu delucchi-cmu commented Oct 28, 2024 •
edited
Loading

Remove uninteresting failing test.

Fixes smoke tests by removing a unit test that fails with introduction of astronomy-commons/hats#374.

The test isn't really testing cloud functionality in an interesting way, so I've just removed the test.

Update read_hats

Type-specific calls removed in PR astronomy-commons/hats#394

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Before [21e0ea9] After [f119766] Ratio Benchmark (Parameter)
2.51±1s 2.65±1s 1.05 benchmarks.time_computation
3.93k 2.82k 0.72 benchmarks.mem_list

Click here to view all benchmarks.

@delucchi-cmu delucchi-cmu changed the title Remove uninteresting failing test. Fix smoke test (remove test, update read_hats) Oct 29, 2024
@delucchi-cmu delucchi-cmu merged commit daf1e7f into main Oct 29, 2024
7 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/smoke branch October 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitosaurus gitosaurus gitosaurus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucchi-cmu @gitosaurus