Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc build error with dask client #173

Merged
merged 6 commits into from
Nov 29, 2023
Merged

Fix doc build error with dask client #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f2a755f
Give more failure info.
delucchi-cmu Nov 28, 2023
536e8f1
Maybe the done files aren't written?
delucchi-cmu Nov 28, 2023
cf5e6de
Use same pip as local?
delucchi-cmu Nov 28, 2023
3880c08
Maybe tasks aren't scheduled because they're done.
delucchi-cmu Nov 28, 2023
2da502c
Undo red herring
delucchi-cmu Nov 28, 2023
0b77517
Restructure exception handling
delucchi-cmu Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions docs/notebooks/unequal_schema.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@
" highest_healpix_order=1,\n",
")\n",
"\n",
"client = Client(n_workers=1, threads_per_worker=1)\n",
"\n",
"try:\n",
" pipeline_with_client(args, client)\n",
"except:\n",
" pass # we know it's going to fail!!"
"with Client(n_workers=1, threads_per_worker=1) as client:\n",
" try:\n",
" pipeline_with_client(args, client)\n",
" except:\n",
" pass # we know it's going to fail!!\n",
"tmp_path.cleanup()"
]
},
{
Expand Down Expand Up @@ -137,7 +137,8 @@
" use_schema_file=mixed_schema_csv_parquet,\n",
" overwrite=True,\n",
")\n",
"pipeline_with_client(args, client)"
"with Client(n_workers=1, threads_per_worker=1) as client:\n",
" pipeline_with_client(args, client)"
]
},
{
Expand Down Expand Up @@ -283,7 +284,6 @@
"metadata": {},
"outputs": [],
"source": [
"client.shutdown()\n",
"tmp_path.cleanup()"
]
}
Expand All @@ -304,7 +304,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.11.4"
"version": "3.10.13"
}
},
"nbformat": 4,
Expand Down
10 changes: 5 additions & 5 deletions src/hipscat_import/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,15 @@ def pipeline_with_client(args: RuntimeArguments, client: Client):
macauff_runner.run(args, client)
else:
raise ValueError("unknown args type")
except Exception as exception: # pylint: disable=broad-exception-caught
_send_failure_email(args, exception)
else:

_send_success_email(args)
except Exception as exception: # pylint: disable=broad-exception-caught
if args.completion_email_address:
_send_failure_email(args, exception)
raise exception


def _send_failure_email(args: RuntimeArguments, exception: Exception):
if not args.completion_email_address:
raise exception
message = EmailMessage()
message["Subject"] = "hipscat-import failure."
message["To"] = args.completion_email_address
Expand Down
2 changes: 2 additions & 0 deletions src/hipscat_import/pipeline_resume_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ def wait_for_futures(self, futures, stage_name):
):
if future.status == "error":
some_error = True
print(f"{stage_name} task {future.key} failed with message:")
print(future.exception())
if some_error:
raise RuntimeError(f"Some {stage_name} stages failed. See logs for details.")

Expand Down