Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Margin Cache Hive Columns #199

Merged
merged 4 commits into from
Jan 10, 2024
Merged

Conversation

smcguire-cmu
Copy link
Contributor

Change Description

In the current margin cache generation, the values of the hive columns NOrder, NPix, and Dir are those from the margin's original pixel, and so do not match the hive values in the hipscat directory structure. This renames them to add the prefix margin_, ..., and adds the hive columns that match the path to their pixel in the hipscat structure.
closes #188

  • My PR includes a link to the issue that I am addressing

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ba5bcb) 99.45% compared to head (6945e96) 99.45%.

❗ Current head 6945e96 differs from pull request most recent head ad0e318. Consider uploading reports for the commit ad0e318 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files          29       29           
  Lines        1455     1461    +6     
=======================================
+ Hits         1447     1453    +6     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smcguire-cmu smcguire-cmu merged commit 3c87019 into main Jan 10, 2024
11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/rename-margin-columns branch January 10, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename common columns for margin cache generation
2 participants