Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pathlib for pytest fixtures. #333

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Use pathlib for pytest fixtures. #333

merged 2 commits into from
Jun 11, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

This PR touches only files under tests/, and changes code to use pathlib.Path for constructing test data paths, instead of os.path.join.

This shouldn't change any functionality, but is just cleaner.

Code Quality

  • I have read the Contribution Guide and LINCC Frameworks Code of Conduct
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

@delucchi-cmu delucchi-cmu requested a review from hombit June 10, 2024 19:39
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (3bcec06) to head (4439aca).
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          26       26           
  Lines        1389     1389           
=======================================
  Hits         1386     1386           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hombit hombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

tests/hipscat_import/catalog/test_map_reduce.py Outdated Show resolved Hide resolved
@delucchi-cmu delucchi-cmu merged commit 04c1a8f into main Jun 11, 2024
9 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/pathlib branch June 11, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants