Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSV reader from recent changes in hipscat library #359

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

delucchi-cmu
Copy link
Contributor

Change Description

Use appropriate scope for pandas chunk reading generator, with file-ownership in hipscat method.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.72%. Comparing base (3cd24f6) to head (c4ba1b2).
Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   99.72%   99.72%   -0.01%     
==========================================
  Files          26       26              
  Lines        1455     1454       -1     
==========================================
- Hits         1451     1450       -1     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@camposandro camposandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@delucchi-cmu delucchi-cmu merged commit aac8b9b into main Jul 29, 2024
9 of 10 checks passed
@delucchi-cmu delucchi-cmu deleted the delucchi/smoke branch July 29, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants